-
Notifications
You must be signed in to change notification settings - Fork 617
This issue was moved to a discussion.
You can continue the conversation there. Go to discussion →
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the Java Units Library with additional methods and unit types #6683
Comments
I love the Java units library. One of the barriers to entry I feel is writing a method that returns a type. That type is something like acceleration. The type signature for the method is Measure<Velocity<Velocity>>>. This is a little inelegant and people will just look away and handle units in their own way. However this seems more to be due to the limitations of Java than anything else. Adding a unit for force and torque is fine, but a method returning this type would have a signature is ridiculous. The library itself seems to have some issues separating Dimension, Unit, and Physical quantity. Torque and Energy are two physical quantities, they are measured with the same dimension. That dimension can be captured in a variety of named units that are also characterized by a dimension. I feel like instead of Measure it should be more Measure. Each dimension should have its own list of units. Internally a dimension can either be a base dimension (like mass or current, or time, I'm going by the SI unit definition here) or a composite dimension like Nm or J/S. Under the hood every dimension is a product of these base dimensions, quotients being negative integer powers. Nm is just Mass * Distance * Distance * Second^-1 * Second^-1. |
I agree with the separation being confusing, for example the library has Power as its own sort of unit when it could be work/energy over time. Same thing with the torque units, I feel like it would be cleaner to have Torque be its own unit instead of deriving it from the other base units because it would become extremely cumbersome to define a method to take in or return some unit of torque. |
So every dimension in SI is built up of integer power of base units. One can remove the unit concept entirely from the picture and think in terms of dimension Torque and Energy are measurable things. A measurable thing has a dimension. Units are when we go from dimension to measurements of those measurable things. The main dimensions are time, mass, electric current, temperature, substance and luminous intensity. |
You mean
Yes, Java's type system is very limiting in what we can do for units. Unlike C++, there is no ability in Java to define type aliases like
I think something was lost here? |
This issue was moved to a discussion.
You can continue the conversation there. Go to discussion →
Coming from the C++ units library, the Java units library has a few rough edges that can occasionally make working with the library difficult. Below are some suggestions for unit and feature additions to improve the usability of the library, based on both my experience with the library so far and our requirements for the library at CTRE.
Unit Additions
Velocity<Dimensionless>
?)Functionality Improvements
Unfortunately, there may be some limitations of Java that prevent all these suggestions from being implemented, but I believe we should add whatever we can.
Measure<U1>
by aMeasure<U2>
inverse()
to Measure and UnitValue.of(1).divide(meas)
would also be a method of creating an inverse. Likewise,Meters.mult(Seconds.inverse())
may not give the desired type ofVelocity<Distance>
, although that can probably be handled in documentation.squared()
andcubed()
to UnitMeters.squared()
is equivalent toMeters.mult(Meters)
.Rotations.per(Second.squared())
may not result in a type ofVelocity<Velocity<Angle>>
.The text was updated successfully, but these errors were encountered: