Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with some special characters, especially apostrophes [includes fix] #26

Open
Scr4tchproof opened this issue Dec 7, 2023 · 0 comments

Comments

@Scr4tchproof
Copy link

Scr4tchproof commented Dec 7, 2023

Hi there,

First of all, thank you for the awesome extension. I absolutely love it.

I've noticed that it however had an issue with some special characters, especially apostrophes. So instead of saying "I'm" or "I'd" or "he's", it would say the first letter than it would say the character code instead of the apostrophes.

I've looked into script.py and managed to fix the issue by doing the following:

From line 150

Right under

def output_modifier(string, state):

I added

string = string.replace("'", "'")

So that it looks like this:

def output_modifier(string, state):
    string = string.replace("'", "'")
    global model, current_params, streaming_state

This completely fixed the issue for me.

I haven't really found a way to fix quotes yet. I believe the TTS reads them as "in quote", but I'm not sure if this solution could help in such instances as well.

I'm sorry if this is not how these things should be reported, I'm not very versed in all this.

Just hope this helps.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant