Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop Logging the Request Parameters of DSS Operation in case of error scenario #3123

Closed
veneerac opened this issue Aug 28, 2023 · 1 comment

Comments

@veneerac
Copy link

Problem

If an error occurs in the Nested Exception DSS use case, the added parameters, their values, and the payload are printed to the logs. This is a security concern , as it could expose sensitive information such as passwords and usernames. Additionally, if the payload is large, it can also be a performance issue. Masking the sensitive data in the logs is not a solution for this, when payloads are large and dynamic.

Screenshot from 2023-08-23 17-39-36

Refined Steps to Reproduce the Issue:

  1. Setting up the Data Service:
    Begin by creating a data service utilizing a sample database. You can follow the documentation [1] to access and comprehend the sample data service provided. This service will serve as the context for reproducing the issue.

  2. Triggering the Data Service with an Invalid Payload:
    Next, intentionally invoke the data service using an invalid payload.

[1] Reference the provided documentation for guidance on creating and using the sample data service.

[1] https://ei.docs.wso2.com/en/latest/micro-integrator/use-cases/examples/data_integration/rdbms-data-service/

Solution

Introduce the property to disable logging params

Affected Component

MI

Version

EI 6.x.x and MI

Implementation

No response

Related Issues

No response

Suggested Labels

No response

@GDLMadushanka
Copy link
Contributor

Fixed by #2956

@dulanjalidilmi dulanjalidilmi transferred this issue from wso2/api-manager Feb 20, 2024
@dulanjalidilmi dulanjalidilmi added this to the 4.3.0-M1 milestone Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants