Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature(AC):Prompt_tone does not stay disabled #383

Open
BenJewell opened this issue Nov 9, 2024 · 11 comments
Open

Feature(AC):Prompt_tone does not stay disabled #383

BenJewell opened this issue Nov 9, 2024 · 11 comments

Comments

@BenJewell
Copy link

HA core version

2024.11.1

Current integration version

0.6.5

Last known working integration version

georgezhao2010 version

Device type and model

Air Conditioner 00000Q17 (0)

Working mobile app

SmartHome

The detail description of bug/problem

I am trying to disable prompt_tone so my units never beep. In the old georgezhao2010 integration, I was able to change the default from FALSE to TRUE in the Python code itself. I can't find a place to do that in the current code. I tried adding a custom parameter like this using both "false" and "0". The temp step gets set correctly, but the prompt tone turns back on with every reboot of Home Assistant.

image

I am able to disable it using the "Extra controls" toggle, but this only lasts until rebooting.

The logs

I think this is the relevant debug log section. If not, please let me know.

Midea log.txt

@BenJewell BenJewell added the bug Something isn't working label Nov 9, 2024
@BenJewell
Copy link
Author

Here is how I used to change it in the old version:

image

@wuwentao
Copy link
Owner

I'm sorry, I don't know why you can't add prompt tone as a extra control, then you can control it without any setting.
please check the detail.
if it still can't work for your device, could you share me your device SN and provided your device info in midea_ac_lan device detail web UI.

below is my AC device :
screenshot-20241111-004428

once it done, I can control it without any setting.
so we need to confirm your device protocol/type/subtype/etc to confirm your issue.

@BenJewell
Copy link
Author

I CAN add prompt tone an extra control and it works fine. I'm trying to permanently disable prompt tone for all units, but it turns back on every time Home Assistant restarts.

I spent hours looking at the code and can't figure out where the current version is getting this default state of "true" (enabled) from.

Where that attribute is declared in the code for an AC class device, I tried adding "default: False", but even that does not work.

@erikgieseler
Copy link
Contributor

The default value probably comes from the midea-local lib, see screenshot.
midea-local

@BenJewell
Copy link
Author

Thanks, that's what I was looking for! But where is this library stored? It doesn't seem to be where the integration is installed, inside custom_components/midea_ac_lan. I installed this with HACS if that matters.

@erikgieseler
Copy link
Contributor

You can find out the path of midea-local as follows, see: #319 (comment)

@BenJewell
Copy link
Author

Thank you! I will use that fix for now.
Let me know if you need anything else from me to get the value in the "customize" box working in the future.

@wuwentao
Copy link
Owner

thanks @erikgieseler to help for this issue.

@BenJewell it's a special feather requirement: try to change the device attribute default value.

in addition, I have a holiday for some weeks now, and current github feature support issue will have some delay.

anyway, I will check with the details to confirm with it after some weeks.

@BenJewell
Copy link
Author

Thanks @wuwentao for following up on this!

I disagree with it being a special requirement for two reasons:

  1. It defies the typical behavior of the Midea hardware in that the AC devices remember not to beep if you turn off beeping from the remote or the official app, and simply running the Home Assistant integration breaks this existing functionality. This seems to be model specific. For example the wall unit and ceiling cassette mini splits from the same series behave differently.
  2. This one is more of an opinion but beeping is loud and useless so the vast majority would probably not want it. There aren't even guides online on how to break the pizio electric speaker.

That being said, I respect that you are volunteering your time for this effort and are free to prioritize things however you want. I always appreciate any contributions!

@wuwentao
Copy link
Owner

Thanks @wuwentao for following up on this!

I disagree with it being a special requirement for two reasons:

  1. It defies the typical behavior of the Midea hardware in that the AC devices remember not to beep if you turn off beeping from the remote or the official app, and simply running the Home Assistant integration breaks this existing functionality. This seems to be model specific. For example the wall unit and ceiling cassette mini splits from the same series behave differently.
  2. This one is more of an opinion but beeping is loud and useless so the vast majority would probably not want it. There aren't even guides online on how to break the pizio electric speaker.

That being said, I respect that you are volunteering your time for this effort and are free to prioritize things however you want. I always appreciate any contributions!

midea device can storage default value setting, if we want to have the same feature, we also need to storage these attribute and latest value to HA storage, and not only for prompt_tone, most of these attributes and values should be saved for future.
in addition, from HA integration side and midea_ac_lan, it's two different software and solution, so it should be a new feature support, and we can try to add the same software feature in HA like midea hardware device, there will be too many feature need to be confirm, for example, we need to save these attributes setting and try to load it when device reboot.

@BenJewell
Copy link
Author

Okay thanks! I didn't realize it was that complex. I see what you mean about not being able to change the default on the Midea side since it seems to be hard coded into the unit firmware basically.

@wuwentao wuwentao changed the title Prompt_tone does not stay disabled Feature(AC):Prompt_tone does not stay disabled Nov 17, 2024
@wuwentao wuwentao added add_new_feature and removed bug Something isn't working labels Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants