Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include stubs for all layouts available in govuk-eleventy-plugin #221

Open
paulrobertlloyd opened this issue Mar 13, 2023 · 2 comments
Open

Comments

@paulrobertlloyd
Copy link
Collaborator

If you try to use a layout documented in the plugin guidance (i.e. sub-navigation), the site won't build. We can save any such issues by including stubs for all available layouts. For example:

{% extends "layouts/sub-navigation.njk" %}

See: https://github.com/Methods-Design-Team/Titan-design-history/pull/5

@vickytnz
Copy link

Agree with this - it's a bit confusing to ostensibly have the original plugin available but also … not?

@paulrobertlloyd
Copy link
Collaborator Author

Eleventy 3.0 is coming out soon, and it has much smarter way for plugins to provide layouts. I need to experiment with the changes, but it looks like setup and layout overrides can be greatly simplified, meaning issues like this will go away. 🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants