Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

partitions not properly wiped #624

Open
ydirson opened this issue Jul 5, 2023 · 4 comments
Open

partitions not properly wiped #624

ydirson opened this issue Jul 5, 2023 · 4 comments

Comments

@ydirson
Copy link
Contributor

ydirson commented Jul 5, 2023

In reports like xcp-ng/xcp#390 and https://xcp-ng.org/forum/topic/7465/upgrade-to-8-3-beta-1-fails we see users getting hit by a previous ZFS partition not being properly wiped.

util.zeroOut uses dd to clear explicit block ranges in a given block dev (which cannot account for all kinds of signatures in the wild), and tools like vgcreate are used in a mode that would ask the user what to do. Would there be any problem in calling wipefs -a on the target block device?

I can see it could be a bad idea to use --force on vgcreate, as it is quite an "override all checks" flag and there don't seem to be a flag to just ignore previous contents, although it could avoid any upcoming issues that would not be covered by the current wipefs version.
@MarkSymsCtx
Copy link
Contributor

I think a call to wipefs -a sounds entirely reasonable to resolve this issue.

@ydirson
Copy link
Contributor Author

ydirson commented Jul 5, 2023 •
edited
Loading

It would seem useful for all SR types, so the "sr_create" handling in SRCommand.run would be the place, right?

... except for all those to which it would not apply

ydirson added a commit to xcp-ng/sm that referenced this issue Jul 5, 2023
@ydirson
lvutil: use wipefs not dd to clear existing signatures (xapi-project#624
723c440 
)
ydirson added a commit to xcp-ng/sm that referenced this issue Jul 5, 2023
@ydirson
lvutil: use wipefs not dd to clear existing signatures (xapi-project#624
4a97f7b 
)
@MarkSymsCtx
Copy link
Contributor

It would seem useful for all SR types, so the "sr_create" handling in SRCommand.run would be the place, right?

... except for all those to which it would not apply

Indeed, I suspect you'd get errors on File based SRs. It could probably go in the LVHDSR class though.

@ydirson
Copy link
Contributor Author

ydirson commented Jul 5, 2023

I'm going with createVG, so EXTSR can benefit from it too

ydirson added a commit to xcp-ng/sm that referenced this issue Jul 5, 2023
@ydirson
lvutil: use wipefs not dd to clear existing signatures (xapi-project#624
adc358a 
)
ydirson added a commit to xcp-ng/sm that referenced this issue Jul 5, 2023
@ydirson
lvutil: use wipefs not dd to clear existing signatures (xapi-project#624
1a2022c 
)
ydirson added a commit to xcp-ng/sm that referenced this issue Jul 5, 2023
@ydirson
lvutil: use wipefs not dd to clear existing signatures (xapi-project#624
1efd6b0 
)
ydirson added a commit to xcp-ng/sm that referenced this issue Jul 6, 2023
@ydirson
lvutil: use wipefs not dd to clear existing signatures (xapi-project#624
92989f1 
)

Signed-off-by: Yann Dirson <[email protected]>
ydirson added a commit to xcp-ng/sm that referenced this issue Jul 6, 2023
@ydirson
lvutil: use wipefs not dd to clear existing signatures (xapi-project#624
f7d8efe 
)

Signed-off-by: Yann Dirson <[email protected]>
@MarkSymsCtx MarkSymsCtx mentioned this issue Jul 7, 2023
Open
ydirson added a commit to xcp-ng/sm that referenced this issue Jul 24, 2023
@ydirson
lvutil: use wipefs not dd to clear existing signatures (xapi-project#624
30f6009 
)

Signed-off-by: Yann Dirson <[email protected]>
ydirson added a commit to xcp-ng/sm that referenced this issue Jan 11, 2024
@ydirson
lvutil: use wipefs not dd to clear existing signatures (xapi-project#624
09aa30e 
)

Signed-off-by: Yann Dirson <[email protected]>
ydirson added a commit to xcp-ng/sm that referenced this issue Jan 16, 2024
@ydirson
lvutil: use wipefs not dd to clear existing signatures (xapi-project#624
a08ad58 
)

Signed-off-by: Yann Dirson <[email protected]>
ydirson added a commit to xcp-ng/sm that referenced this issue Jan 18, 2024
@ydirson
lvutil: use wipefs not dd to clear existing signatures (xapi-project#624
b9b275f 
)

Signed-off-by: Yann Dirson <[email protected]>
Wescoeur pushed a commit to xcp-ng/sm that referenced this issue Jan 19, 2024
@ydirson @Wescoeur
lvutil: use wipefs not dd to clear existing signatures (xapi-project#624
f265bd6 
)

Signed-off-by: Yann Dirson <[email protected]>
Wescoeur pushed a commit to xcp-ng/sm that referenced this issue Jan 19, 2024
@ydirson @Wescoeur
lvutil: use wipefs not dd to clear existing signatures (xapi-project#624
e355611 
)

Signed-off-by: Yann Dirson <[email protected]>
Wescoeur pushed a commit to xcp-ng/sm that referenced this issue Jan 23, 2024
@ydirson @Wescoeur
lvutil: use wipefs not dd to clear existing signatures (xapi-project#624
998023d 
)

Signed-off-by: Yann Dirson <[email protected]>
Wescoeur pushed a commit to xcp-ng/sm that referenced this issue Jan 23, 2024
@ydirson @Wescoeur
lvutil: use wipefs not dd to clear existing signatures (xapi-project#624
55773b1 
)

Signed-off-by: Yann Dirson <[email protected]>
Wescoeur pushed a commit to xcp-ng/sm that referenced this issue Jan 23, 2024
@ydirson @Wescoeur
lvutil: use wipefs not dd to clear existing signatures (xapi-project#624
7592843 
)

Signed-off-by: Yann Dirson <[email protected]>
Wescoeur pushed a commit to xcp-ng/sm that referenced this issue Jan 23, 2024
@ydirson @Wescoeur
lvutil: use wipefs not dd to clear existing signatures (xapi-project#624
3bee822 
)

Signed-off-by: Yann Dirson <[email protected]>
Wescoeur pushed a commit to xcp-ng/sm that referenced this issue Jan 26, 2024
@ydirson @Wescoeur
lvutil: use wipefs not dd to clear existing signatures (xapi-project#624
70e81bf 
)

Signed-off-by: Yann Dirson <[email protected]>
Wescoeur pushed a commit to xcp-ng/sm that referenced this issue Feb 6, 2024
@ydirson @Wescoeur
lvutil: use wipefs not dd to clear existing signatures (xapi-project#624
fe315bc 
)

Signed-off-by: Yann Dirson <[email protected]>
Wescoeur pushed a commit to xcp-ng/sm that referenced this issue Feb 12, 2024
@ydirson @Wescoeur
lvutil: use wipefs not dd to clear existing signatures (xapi-project#624
3f3eba6 
)

Signed-off-by: Yann Dirson <[email protected]>
@lethedata lethedata mentioned this issue Feb 17, 2024
Open
Wescoeur pushed a commit to xcp-ng/sm that referenced this issue Feb 22, 2024
@ydirson @Wescoeur
lvutil: use wipefs not dd to clear existing signatures (xapi-project#624
03b2c03 
)

Signed-off-by: Yann Dirson <[email protected]>
Wescoeur pushed a commit to xcp-ng/sm that referenced this issue Apr 10, 2024
@ydirson @Wescoeur
lvutil: use wipefs not dd to clear existing signatures (xapi-project#624
ded906b 
)

Signed-off-by: Yann Dirson <[email protected]>
Wescoeur pushed a commit to xcp-ng/sm that referenced this issue Apr 11, 2024
@ydirson @Wescoeur
lvutil: use wipefs not dd to clear existing signatures (xapi-project#624
99ea721 
)

Signed-off-by: Yann Dirson <[email protected]>
benjamreis pushed a commit to xcp-ng/sm that referenced this issue Jun 24, 2024
@ydirson @benjamreis
lvutil: use wipefs not dd to clear existing signatures (xapi-project#624
a5235a5 
)

Signed-off-by: Yann Dirson <[email protected]>
Wescoeur pushed a commit to xcp-ng/sm that referenced this issue Jun 26, 2024
@ydirson @Wescoeur
lvutil: use wipefs not dd to clear existing signatures (xapi-project#624
fb64ed6 
)

Signed-off-by: Yann Dirson <[email protected]>
Wescoeur pushed a commit to xcp-ng/sm that referenced this issue Jun 28, 2024
@ydirson @Wescoeur
lvutil: use wipefs not dd to clear existing signatures (xapi-project#624
a3dbbe1 
)

Signed-off-by: Yann Dirson <[email protected]>
benjamreis pushed a commit to xcp-ng/sm that referenced this issue Aug 12, 2024
@ydirson @benjamreis
lvutil: use wipefs not dd to clear existing signatures (xapi-project#624
795c007 
)

Signed-off-by: Yann Dirson <[email protected]>
benjamreis pushed a commit to xcp-ng/sm that referenced this issue Aug 12, 2024
@ydirson @benjamreis
lvutil: use wipefs not dd to clear existing signatures (xapi-project#624
1f46bf9 
)

Signed-off-by: Yann Dirson <[email protected]>
benjamreis pushed a commit to xcp-ng/sm that referenced this issue Aug 13, 2024
@ydirson @benjamreis
lvutil: use wipefs not dd to clear existing signatures (xapi-project#624
eb05526 
)

Signed-off-by: Yann Dirson <[email protected]>
benjamreis pushed a commit to xcp-ng/sm that referenced this issue Aug 13, 2024
@ydirson @benjamreis
lvutil: use wipefs not dd to clear existing signatures (xapi-project#624
3bb77ee 
)

Signed-off-by: Yann Dirson <[email protected]>
benjamreis pushed a commit to xcp-ng/sm that referenced this issue Aug 13, 2024
@ydirson @benjamreis
lvutil: use wipefs not dd to clear existing signatures (xapi-project#624
709b30f 
)

Signed-off-by: Yann Dirson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ydirson @MarkSymsCtx