Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xata pull not writing files synchronously? #1239

Closed
richardgill opened this issue Nov 3, 2023 · 2 comments
Closed

xata pull not writing files synchronously? #1239

richardgill opened this issue Nov 3, 2023 · 2 comments
Assignees
Labels
bug Something isn't working needs-triage

Comments

@richardgill
Copy link
Contributor

Describe the bug

I ran this command in my terminal:

(cd apps/website && xata pull main) && git commit -am ‘removed gitsha column’ && git push

Then when I came back to my terminal I noticed some migration files that were 'untracked' in git.

Does xata pull wait for the files to be written before returning?

@richardgill richardgill added the bug Something isn't working label Nov 3, 2023
@SferaDev
Copy link
Member

SferaDev commented Nov 5, 2023

I was checking the code and it looks like we wait for all write operations to succeed before returning. Looks like something to investigate for sure.

@eemmiillyy
Copy link
Contributor

TIL using the -a flag will only add modified files, NOT new or deleted files. In the commit where this was experienced, new files were being added rather than modified which explains why they weren't part of the commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs-triage
Projects
None yet
Development

No branches or pull requests

3 participants