Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use monthly or yearly time delta #68

Open
TonioF opened this issue Oct 8, 2021 · 1 comment
Open

Do not use monthly or yearly time delta #68

TonioF opened this issue Oct 8, 2021 · 1 comment

Comments

@TonioF
Copy link
Contributor

TonioF commented Oct 8, 2021

xcube-sh has parameters 'time_period' and 'time_tolerance' that are noth internally converted to a pandas timedelta object. In case of monthly or yearly values, the following warning is given:

FutureWarning: Units 'M', 'Y' and 'y' do not represent unambiguous timedelta values and will be removed in a future version

This means that xcube-sh in its current form will not be able to work with future versions of pandas. A solution could be to handle the internal representation of the time delta differently.

@forman forman self-assigned this Oct 18, 2021
@forman forman added the in progress Work addressing this issue has started label Oct 18, 2021
@forman forman removed the in progress Work addressing this issue has started label Nov 10, 2021
@forman
Copy link
Member

forman commented Feb 22, 2023

Another workaround is to not use ambiguous units 'M', 'Y' and 'y', but use D or W instead. A parameter validation could prevent from using ambiguous units.

@forman forman removed their assignment Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants