Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS bug: content: " (" #2

Open
tomByrer opened this issue Jan 4, 2014 · 5 comments
Open

CSS bug: content: " (" #2

tomByrer opened this issue Jan 4, 2014 · 5 comments

Comments

@tomByrer
Copy link

tomByrer commented Jan 4, 2014

In the Bootstrap.css:

content: " (" attr(href) ")"

is compressed as

content:"(" attr(href)")"

should be

content:" ("attr(href)")"

Otherwise, neat tool(s)!

@xem
Copy link
Owner

xem commented Jan 4, 2014

Indeed, my CSS & JS minifiers don't handle strings yet, but I'll try to fix that. Thanks!

@tomByrer
Copy link
Author

tomByrer commented Jan 4, 2014

Thanks for your consideration!
If you want, I can PR on yourindex.html to add a warning, unless you plan to fix it soonish?

@xem
Copy link
Owner

xem commented Jan 4, 2014

I added the warnings in the CSS & JS pages.
I don't know how to fix it yet, though :) please be patient.

@tomByrer
Copy link
Author

tomByrer commented Jan 4, 2014

Cheers!
Take your time :) I just happened to have SO window open; this could help?
BTW, this REGEX testing tool is fun :)

@xem
Copy link
Owner

xem commented Jan 4, 2014

Thanks for those links! That will be handy.
Oh and if you're into regexes, feel free to try and fix the CSS minifier and send a PR ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants