Segmentation fault in sctp_data_received_cb

[JulienDuf]

I'm trying to use librtcdc for peer to peer connection and for data transfer. The peer to peer connection works perfectly. But when one peer creates a data channel, the other peer always ends with a Segmentation fault in the sctp_data_received_cb function of stcp.c

I create my data channel in the on_connect callback :

void PeerConnection_OnConnect(PeerConnection *peer, void *user_data)
{
        App* app = (App*)user_data;
        printf("OnConnection" "\n");
        app->dataChannel = rtcdc_create_data_channel(app->connection, "data", "", PeerConnection_OnOpen, PeerConnection_OnMessage, PeerConnection_OnClose, app);
}

Am I the only one with that problem ?

[xhs]

Hi @JulienDuf , could you show me the rtcdc_on_channel_cb function?

[JulienDuf]

For the moment I'm doing this :

void PeerConnection_OnChannel(PeerConnection *peer, DataChannel *channel, void *user_data)
{
        printf("OnChannel" "\n");
}

But the callback is never called.

[xhs]

Let me see...what if you add -DDEBUG_SCTP when you compile this code, can you see something like "data of length %zu received on stream %u with SSN %u, TSN %u, PPID %u\n"?

[JulienDuf]

No, because the seg fault is there :

struct rtcdc_transport *transport = peer->transport;

When the program is in this function, every parameters are invalid (they have junk in them).

This might be a problem of multithreading, two threads working with the sctp transport at the same time.

[xhs]

The name user_data in sctp_data_received_cb is confusing, I have renamed it to peer_data. Generally, it should not be touched. I will look into it. :(