Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature-Gate Server and Client derives #60

Open
insipx opened this issue Feb 12, 2024 · 0 comments
Open

Feature-Gate Server and Client derives #60

insipx opened this issue Feb 12, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@insipx
Copy link
Contributor

insipx commented Feb 12, 2024

Is your feature request related to a problem?

We don't have server and client behind feature gates, which means even if a client only wants client code, they will pull in all server code.

Describe the solution to the problem

We should feature-gate the client and server code similar to how it is in lib_didethresolver: https://github.com/xmtp/didethresolver/blob/main/lib/src/rpc.rs

Note: we should make sure that the client feature gate in xps also only compiles lib_didethresolver with the client feature or no features (as to not pull in any rpc code from lib-didethresolver)

Describe the uses cases for the feature

Libxmtp compiles to wasm, and its important to remove unnecessary code from the resulting blob.

@insipx insipx added the enhancement New feature or request label Feb 12, 2024
@insipx insipx moved this to Todo in D14N Work Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Todo
Development

No branches or pull requests

1 participant