-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stop due to errors issues!! #16
Comments
any update boss? |
Hey @blackcodersec . Sorry, I seemed to miss this one. The errors that occur can be related to the KNOXSS API, and carrying on processing could potentially be a waste of time and better to run again later. |
If 6-10 errors are found in the output knoxnl auto stops the process and creates a new file which is filename..todo. But I want here that if the requests get the error while scanning, the scan will be full. And please don't update your script version by updating some code. |
Hey @blackcodersec . Thanks for raising an issue. The problem with the filename getting bigger has been fixed in the latest version I released yesterday. |
hey @xnl-h4ck3r, Is it possible boss? |
Sorry, I don't fully understand what you are asking. Do you mean that even if there are errors with the API, that you want it to continue even though they're likely to fail? |
Yes, there is no API error, sometimes some subdomain blocks knoxss IP, so it shows some error, but if knoxnl finds more than 6-10 times error, knoxnl stops auto scan. which is bad (I think) |
It shouldn't stop on those errors. In your example screenshot it stopped because it was failing to connect to KNOXSS itself rather than issues with the targets through the API. |
Ho @blackcodersec . Again the last errors that caused it to stop were the API timing out and then being unable to establick a connection to the API. If we can't contact the API, everything would fail if we carry on, |
I'll look into this more to try anf figure out the issue |
HI @blackcodersec. So the code currently works in a way that it will stop if one of these happens:
So it's the first 2 points are the problem here. These imply an issue with the API and maybe it is overloaded and unable to accept a new connection at that time. I'm thinking of making a change that will pause for 30 seconds if one of these API issues happen, and then try again. Maybe have an argument for the amount of retries and seocnds to wait, and default to 3 and 30 seconds respectively. What do you think? |
I think it would be good. another thing is, I think knoxss server config is not good. most of the time url not scanned fully. |
If there's any issues with KNOXSS API itself, you'll need to speak to them directly about that. I'm not sure what you mean by "not scanned fully" though. Are you referring to an issue with KNOXSS API, or with knoxnl? |
I am asking to Knoxss, and he told me, now Knoxss has to handle a lot of requests, so sometimes there are problems with requests.
That's why, I think it would be good. |
Hi @blackcodersec, I think is is related with an issue with the KNOXSS API itself. It happens when there is a runtime error of |
|
Hi @Nishantbhagat57. It stopped because there was an issue with the KNOXSS API. Unfortunatley there is much I can do if the API is having issues. I am working on a change to wait for a while when the API is having problems to try again a few times before stopping. |
your idea is good, and the script as well. but I think this idea is very bad. because I have an API request, but this function just stops the process and makes *****.todo files. which is weird to use this script again and again. could you make the new function to force the request to complete the file scan?
The text was updated successfully, but these errors were encountered: