Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stratification_frequency only returns 'inner' w-points #1

Open
hetland opened this issue May 22, 2020 · 1 comment
Open

stratification_frequency only returns 'inner' w-points #1

hetland opened this issue May 22, 2020 · 1 comment

Comments

@hetland
Copy link
Collaborator

hetland commented May 22, 2020

The vertical coordinate in stratification frequency requires quite a bit of wrangling, dropping and replacing vertical coordinates. This part could be re-written to be simpler and more clear. I hope @dcherian could help with this.

The recombined resulting DataArray is on vertical w-points, as it should be, but only the inner points are defined. This will make it difficult to work well with other ROMS DataArrays that are defined on the 'outer' vertical points by default. It would be better to extrapolate values to the surface and bottom, or replace these with boundary values (i.e., zero at the bottom).

hetland pushed a commit that referenced this issue May 11, 2021
Making sure kthyng and hetland versions identical
@kthyng
Copy link
Contributor

kthyng commented May 24, 2023

Hi @hetland! I've recently put out a new version to PyPI (v0.2.4, still coming through on conda-forge). Please check to see if this issue is still present in the new version so that over time we can work to address these. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants