Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make TSFE optional #138

Closed
georgringer opened this issue Mar 14, 2024 · 1 comment · Fixed by #151
Closed

Make TSFE optional #138

georgringer opened this issue Mar 14, 2024 · 1 comment · Fixed by #151
Labels
bug

Comments

@georgringer
Copy link
Contributor

Don't know if you want to support this but to be able to use the OAuthService for BE usage I needed to modify one method.

getAuthorizationUrl calls $this->getTSFE() which is null in backend.

I suggest:

  • make return value of getTSFE to allow null
  • check that in getAuthorizationUrl and only it if not null
@liayn
Copy link
Collaborator

liayn commented May 3, 2024

Related to #141

liayn added a commit to liayn/t3ext-oidc that referenced this issue May 3, 2024
@liayn
[BUGFIX] Cope with missing TSFE
235b013 
If for some reason TSFE is not available, use "en" as fallback language.

Resolves: xperseguers#138
@liayn liayn added the bug label May 3, 2024
@liayn liayn mentioned this issue May 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[BUGFIX] Cope with missing TSFE liayn/t3ext-oidc
2 participants
@liayn @georgringer