Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Add ability to toggle using Proxmox host as SSH gateway #432

Open
jbmay opened this issue Feb 4, 2025 · 4 comments
Open

Comments

@jbmay
Copy link

jbmay commented Feb 4, 2025

Based on previous issues it seems that when connecting to Proxmox VMs discovered by xpipe it assumes the VMs won't be directly reachable and attempts to use the Proxmox host as an SSH gateway. This causes issues when attempting to connect to Proxmox VMs via an identity that uses SSH keys since they need to be configured on the Proxmox host.

Ideally I think there should be an option on the "Proxmox systems" connection settings to allow disabling using an SSH gateway altogether and probably also adding the ability to customize the gateway used for VM connections instead of always using the Proxmox host for those that do need a gateway to access their VMs. This would be similar to the gateway settings for a simple SSH connection, but apply to all the proxmox VMs discovered on the host.

Currently the only thing configurable on this settings page is to customize the name of the connection.

Image

Related to this would be the ability to override these newly requested "Proxmox systems" settings on a per VM basis to support the need for different VMs potentially requiring different SSH gateways.

@crschnick
Copy link
Member

So right now it should use any SSH identities from your local machine. You shouldn't have to set them up on your Proxmox host. If it doesn't, then there is something not working correctly.

Previously, this was indeed a limitation. But since these older issues, this should have been fixed

@jbmay
Copy link
Author

jbmay commented Feb 5, 2025

Yeah I found my specific issue I was hitting. For some reason to get connections from the laptop I am currently testing things with to be accepted I had to explicitly add a PubkeyAcceptedAlgorithm to the VM I am trying to connect to in order for the SSH connections to be accepted. Other computers and VMs could connect with the same key without adding that. So what I am hitting isn't an xpipe issue.

I do still think being able to customize the SSH gateway for connecting to proxmox VMs is a worthwhile feature though rather than always connecting through the proxmox host.

@crschnick
Copy link
Member

Alright, I see the point of being able to customize that. I can maybe think of whether this would be possible.

About the PubKey algorithms, yeah that is outside the scope of xpipe and has something to do with your local ssh client or sshd config.

@jbmay
Copy link
Author

jbmay commented Feb 6, 2025

Yeah copy that about the key issue being out of scope. I just didn't realize that was the issue I was hitting before I opened the issue.

I appreciate the consideration for the feature request though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants