compatibility with SingleDatasetRest

[jhamman]

I expected the following to work:

import xarray as xr
import xpublish
from xpublish_opendap import OpenDapPlugin


ds = xr.tutorial.open_dataset("air_temperature")

rest = xpublish.SingleDatasetRest(
    ds,
    plugins={
        "opendap": OpenDapPlugin(),
    },
)

rest.serve(host="localhost", port=9999)

This does successfully start up an Xpublish server, however, accessing the openap endpoint fails with the following error.

> ncdump -h "http://localhost:9999/opendap"
syntax error, unexpected '{', expecting SCAN_ATTR or SCAN_DATASET or SCAN_ERROR
context: {^"detail":[{"type":"missing","loc":["query","dataset_id"],"msg":"Field required","input":null}]}
ncdump: http://localhost:9999/opendap: NetCDF: Access failure

The missing dataset_id seems important.

BTW, changing the above example to use the standard Rest class does work:

rest = xpublish.SingleDatasetRest(
    {"foo": ds},
    plugins={
        "opendap": OpenDapPlugin(),
    },
)

[abkfenris]

I think that's because we're trying to see if we have a cached version of the OpenDAP-ed dataset kicking around, and that function takes the dataset_id.

xpublish-opendap/xpublish_opendap/plugin.py

Lines 45 to 61 in adf376f

	def get_dap_dataset(
	dataset_id: str,
	ds: xr.Dataset = Depends(deps.dataset),
	cache: cachey.Cache = Depends(deps.cache),
	) -> dap.Dataset:
	"""Get a dataset that has been translated to opendap."""
	# get cached dataset if it exists
	cache_key = f"opendap_dataset_{dataset_id}"
	dataset = cache.get(cache_key)
	# if not, convert the xarray dataset to opendap
	if dataset is None:
	dataset = dap_xarray.dap_dataset(ds, dataset_id)
	cache.put(cache_key, dataset, 99999)
	return dataset

We could probably convert that signature to

        def get_dap_dataset(
            dataset_id: str = "default",
            ds: xr.Dataset = Depends(deps.dataset),
            cache: cachey.Cache = Depends(deps.cache),
        ) -> dap.Dataset:

To support SingleDatasetRest usage.