Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simply including moment-hijri into the project sets global locale for moment to ar-sa #31

Open
mklishevych opened this issue Mar 27, 2018 · 2 comments
Open

Simply including moment-hijri into the project sets global locale for moment to ar-sa #31

mklishevych opened this issue Mar 27, 2018 · 2 comments

Comments

@mklishevych
Copy link

Hi,

Thank you for this plugin.

I've noticed the issue described in the title. I believe it happens because of invoking the updateLocale method. If you see how it's implemented, you will notice that it sets the global locale.

https://github.com/moment/moment/blob/develop/src/lib/locale/locales.js#L143
@hafridi
Copy link

hafridi commented Oct 19, 2022

I'm guessing this was never fixed?

@mklishevych
Copy link
Author

@hafridi maintainer is not really responsive as you can see from the other PRs 🤷‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mklishevych @hafridi