We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hello, I wonder if there is a reason why the xtensor_type_caster_base uses xt::xtensor for the signature
xtensor_type_caster_base
xt::xtensor
xtensor-python/include/xtensor-python/xtensor_type_caster_base.hpp
Line 161 in 719b9d1
instead of using numpy.ndarray[...]
numpy.ndarray[...]
xtensor-python/include/xtensor-python/pyarray.hpp
Line 72 in 719b9d1
In my opinion, using the Numpy name is more descriptive to a Python user, and actually matches the type.
I made a quick test using
_("numpy.ndarray[") + npy_format_descriptor<typename Type::value_type>::name + _("]");
which seems to work.
I could send a PR if you are interested.
Thank you
The text was updated successfully, but these errors were encountered:
Good question! Honestly, I don't remember the why of this decision. @SylvainCorlay @wolfv any idea?
Sorry, something went wrong.
No branches or pull requests
Hello,
I wonder if there is a reason why the
xtensor_type_caster_base
usesxt::xtensor
for the signaturextensor-python/include/xtensor-python/xtensor_type_caster_base.hpp
Line 161 in 719b9d1
instead of using
numpy.ndarray[...]
xtensor-python/include/xtensor-python/pyarray.hpp
Line 72 in 719b9d1
In my opinion, using the Numpy name is more descriptive to a Python user, and actually matches the type.
I made a quick test using
which seems to work.
I could send a PR if you are interested.
Thank you
The text was updated successfully, but these errors were encountered: