Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overlapping glyphs m+@ #5100

Open
Tyriar opened this issue Jul 11, 2024 · 2 comments
Open

Overlapping glyphs m+@ #5100

Tyriar opened this issue Jul 11, 2024 · 2 comments
Labels
area/addon/webgl type/bug Something is misbehaving

Comments

@Tyriar
Copy link
Member

Tyriar commented Jul 11, 2024

Not ideal rendering here with the @ overlapping the m:

image

font size = 12
font family = Hack

@Tyriar Tyriar added type/bug Something is misbehaving area/addon/webgl labels Jul 11, 2024
@jerch
Copy link
Member

jerch commented Jul 25, 2024

@Tyriar When I rewrote the DOM renderer I figured, that the canvas/webgl renderer always applied a smaller width to the glyphs than what the DOM measuring gave me. Maybe there is missing some "sanity pace" between glyphs? Might also be a good idea to get the width perfectly aligned between webgl and DOM renderer.

@Tyriar
Copy link
Member Author

Tyriar commented Jul 25, 2024

I'm planning on perfectly aligning the monaco renderer when I start on that, to do it we need to render each glyph at varying starting x positions (eg. 0, 0.25, 0.5, 0.75). So I'll probably eventually pull some of that into xterm.js.

That wouldn't actually help this problem though as overlapping like this will still happen, for this we need to be able to more gracefully merge the glyphs. In this case we want the m's pixel to take precedence as it's closer to the foreground color.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/addon/webgl type/bug Something is misbehaving
Projects
None yet
Development

No branches or pull requests

2 participants