Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buttons contrast isn't good when changing the Color Theme from the default one #18

Open
ane-gabriela opened this issue Sep 26, 2019 · 0 comments

Comments

@ane-gabriela
Copy link

ane-gabriela commented Sep 26, 2019

The contrast between the background and the text color of the File Manger buttons is really poor, which makes the text almost unreadable, when changing the default Color Theme.

Eg. selecting Superhero (Administration > Look & Feel > Themes) leads to:
Contrast

Eg. selecting Yeti:
Yeti

Environment: Windows 10, XWiki 11.7 with MySQL 5.7 and Chrome 77

FYI - More info on this from Anca as we found this issue also on client testing "The cause of this issue is a choice of the pair of colors in the FileManager css with a pair that does not have the contrast ensured, Buttons are the color of default buttons (because bootstrap) while the text is colorTheme.secondaryColor . I think this property does not even exist anymore in the Flamingo color themes (it's a legacy variable from colibri), which are initialized with default values, so we cannot fix it from color theme config."

@ane-gabriela ane-gabriela added this to the 2.2.11 milestone Sep 26, 2019
@polx polx removed this from the 2.2.11 milestone Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants