From 82e2c890192dc729befb34ddd26a058142aa081f Mon Sep 17 00:00:00 2001 From: David Blankenship <128765777+dblanken-yale@users.noreply.github.com> Date: Mon, 26 Feb 2024 10:06:05 -0500 Subject: [PATCH] fix(YSP-353): override white footer link shadow (#337) When changing to a background that is not white, the links that are decorated with underlines have an attribute of a white shadow on it. This results in a terrible looking link. The way this passed in the past was that we had a white background with a white shadow, so it looked ok. This now mimics the same attempting to match the footer background. Right now we are just targeting the footer since it was found only here, but it makes me wonder if we need the shadow? --- components/01-atoms/controls/text-link/_yds-text-link.scss | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/components/01-atoms/controls/text-link/_yds-text-link.scss b/components/01-atoms/controls/text-link/_yds-text-link.scss index 8ebed4b34..4c0707edb 100644 --- a/components/01-atoms/controls/text-link/_yds-text-link.scss +++ b/components/01-atoms/controls/text-link/_yds-text-link.scss @@ -264,6 +264,12 @@ $global-link-themes: map.deep-get(tokens.$tokens, 'global-themes'); align-items: center; width: fit-content; background-size: calc(100% - var(--size-spacing-3)) var(--thickness); + + // Footer elements with a dark background can't have white shadows + // so this overrides it to match the current background color of the footer. + .site-footer__secondary & { + --color-text-shadow: var(--color-site-footer-background-color); + } } &[data-link-style='no-underline'] {