Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Audio Channel Type Dolby Surround #5

Closed
yanfali opened this issue Apr 19, 2013 · 3 comments
Closed

Missing Audio Channel Type Dolby Surround #5

yanfali opened this issue Apr 19, 2013 · 3 comments

Comments

@yanfali
Copy link
Owner

yanfali commented Apr 19, 2013

Changes to match non-AC3 or DTS audio are accidentally matching subtitles too. Write a unit test that catches it. Shouldn't be happening because the mode has changed, looks like some sort of race on first switch.

@yanfali
Copy link
Owner Author

yanfali commented Apr 19, 2013

This is a test case that triggers the problem. Only subtitles beyond English are detected.

  • title 1:
    • stream: title00.mkv
    • duration: 01:00:49
    • size: 720x480, pixel aspect: 32/27, display aspect: 1.78, 23.976 fps
    • autocrop: 0/0/0/0
    • chapters:
      • 1: cells 0->0, 0 blocks, duration 01:00:49
    • audio tracks:
    • audio tracks:
      • 1, English (AC3) (5.1 ch) (iso639-2: eng), 48000Hz, 384000bps
      • 2, Francais (AC3) (5.1 ch) (iso639-2: fra), 48000Hz, 384000bps
      • 3, Portugues (AC3) (Dolby Surround) (iso639-2: por), 48000Hz, 192000bps
      • 4, Espanol (AC3) (5.1 ch) (iso639-2: spa), 48000Hz, 384000bps
      • 5, Thai (AC3) (5.1 ch) (iso639-2: tha), 48000Hz, 384000bps
    • subtitle tracks:
      • 1, English (iso639-2: eng) (Bitmap)(VOBSUB)
      • 2, Chinese (iso639-2: zho) (Bitmap)(VOBSUB)
      • 3, French (iso639-2: fra) (Bitmap)(VOBSUB)
      • 4, Portuguese (iso639-2: por) (Bitmap)(VOBSUB)
      • 5, Thai (iso639-2: tha) (Bitmap)(VOBSUB)
        `

@yanfali
Copy link
Owner Author

yanfali commented Apr 19, 2013

Weird can't duplicate.

@yanfali yanfali closed this as completed Apr 19, 2013
@yanfali yanfali reopened this Apr 19, 2013
@yanfali
Copy link
Owner Author

yanfali commented Apr 19, 2013

Brain Fart. Need to add Dolby Surround. Also need to investigate ragel throwing errors.

yanfali added a commit that referenced this issue Apr 19, 2013
- add a unit test
- add support for dolby surround channel type
@yanfali yanfali closed this as completed Apr 19, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant