Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use Ember.View (breaks Ember 2.x apps) #28

Open
SaladFork opened this issue Nov 24, 2015 · 3 comments
Open

Don't use Ember.View (breaks Ember 2.x apps) #28

SaladFork opened this issue Nov 24, 2015 · 3 comments

Comments

@SaladFork
Copy link

Installing this addon in a 2.x Ember application causes an error:

Uncaught TypeError: Cannot read property 'extend' of undefined

I suspect from the stack trace this is due to the addon trying to create a view. This code is triggered by the instance initializer trying to look up this view.

Installing ember-legacy-views fixes the issue, since it defines Ember.View. This should either not be required (preferred), or installing ember-key-responder should automatically install ember-legacy-view as well.

@billdami
Copy link

billdami commented Jan 8, 2016

👍 This addon currently breaks my app upon installation when using Ember 2.2.0

@SaladFork
Copy link
Author

This is now particularly annoying as Ember / Ember CLI 2.4 (released today) throw a deprecation warning about ember-legacy-views being included in the app.

@lukemelia
Copy link
Contributor

Hey all, we are strongly considering deprecating this addon in favor of ember-keyboard. Feedback on this is welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants