Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve speed using stringi package #2

Closed
GegznaV opened this issue Oct 7, 2019 · 6 comments
Closed

Improve speed using stringi package #2

GegznaV opened this issue Oct 7, 2019 · 6 comments

Comments

@GegznaV
Copy link

GegznaV commented Oct 7, 2019

I think this pull request is worth attention awalker89/openxlsx#440: extra speed gives more value.

@ycphs
Copy link
Owner

ycphs commented Oct 8, 2019

Currently the checks fail. Maybe you could check the saveWorkbook method.

@ycphs
Copy link
Owner

ycphs commented Oct 16, 2019

@noamross, it would be great if you could apply the changes here as well.

@noamross
Copy link
Contributor

Hi @ycphs. I'm happy to do this though it will take me a bit to get to it. First I wanted to confirm that you've contacted the original maintainer and CRAN about taking over maintenance - I just want to make sure we aren't fragmenting code ecosystem!

@ycphs
Copy link
Owner

ycphs commented Oct 16, 2019

Hi,

I tried to contact him with via mail and linkedin. Do you have another possibility to contact the original maintainer? I just thought that it is a pity that the package has the status orphaned on CRAN.

@noamross
Copy link
Contributor

I don't have any better contact for them. I agree - I would suggest making a small update fixing the current CRAN notes and submitting to take over the maintenance before doing major updates.

@ycphs
Copy link
Owner

ycphs commented Nov 6, 2019

Published on CRAN

Looking for new enhancements and features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants