Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass in plugin options in config.txt #73

Open
yifanlu opened this issue Jul 31, 2017 · 3 comments
Open

Pass in plugin options in config.txt #73

yifanlu opened this issue Jul 31, 2017 · 3 comments

Comments

@yifanlu
Copy link
Owner

yifanlu commented Jul 31, 2017

It might be worth adding optional arguments to plugins by passing any string after the plugin path to the module_start function.

@CelesteBlue-dev
Copy link

I think that it's not really needed because each plugin could make a mypluginconfig.txt file if needed.
Doesn't that improvement risk to break compatibility ?
Regards

@yifanlu
Copy link
Owner Author

yifanlu commented Jul 31, 2017

It won't break compatibility because if you don't pass in any option, nothing different will happen and if you pass in an option that the plugin doesn't know about, it won't handle it. The idea is that it's messy if every plugin has its own config file if they only need like 1 integer or string as configuration.

@coderobe
Copy link

coderobe commented Sep 8, 2017

i have started work on this, currently adding an additional config token to the lexer for this.

https://github.com/coderobe/taihen-parser

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants