-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for a *GAME section #78
Comments
I agree. I had this idea too. |
It's a great idea like I said back in June, there won't be any new Vita stuff coming from me. The most you'll see are bug fixes. |
Are you against any new features in general due to maintenance burden, or are PRs acceptable for features? I completely understand either way. To implement this, I'd need to add code to handle parsing it. I think most of the work would actually occur in taihen-parser, not here...perhaps I should have made the feature request there? I'm not against doing this myself, to be honest. It doesn't seem TOO complex. |
So, I went ahead and implemented it. The above PR is probably the final iteration, unless I missed anything. I rebased a few times after opening that PR to optimize / fix stuff. Compiling taiHEN with those changes in taihen-parser adds the functionality needed to support a GAME section. |
It seams good. |
*ALL is nice, but behaviour often differs from what is expected. Badly coded plugins tend to crash homebrew and system applications, but some are useful even so.
Another token which only applies plugins to "games" -- as in, titles starting in PCSA, PCSE, PCSB, PCSG, etc but not PCSX/NPXS -- would be desirable. It would ease configuration, and shorten my config file by at least 50 lines.
Obviously if someone were to use a stupid titleID for a homebrew, it would cause issues, but nobody has done so yet as far as I am aware.
The text was updated successfully, but these errors were encountered: