From a8fb6063e2cca2b0bf07848f74d01ad63f1e3dd8 Mon Sep 17 00:00:00 2001
From: Sergei Tigrov <rrr-r@ya.ru>
Date: Fri, 12 Apr 2024 18:45:27 +0700
Subject: [PATCH] Update test according to main PR (#255)

---
 CHANGELOG.md                         |  4 +-
 rector.php                           |  5 ++-
 src/Builder/ExpressionBuilder.php    | 16 +++++++
 src/ColumnSchema.php                 |  1 +
 src/DQLQueryBuilder.php              |  3 ++
 src/SqlParser.php                    | 64 ++++++++++++++++++++++++++++
 tests/CommandTest.php                |  5 ++-
 tests/Provider/SqlParserProvider.php | 35 +++++++++++++++
 tests/QueryBuilderTest.php           |  7 +--
 tests/SqlParserTest.php              | 25 +++++++++++
 10 files changed, 157 insertions(+), 8 deletions(-)
 create mode 100644 src/Builder/ExpressionBuilder.php
 create mode 100644 src/SqlParser.php
 create mode 100644 tests/Provider/SqlParserProvider.php
 create mode 100644 tests/SqlParserTest.php

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 7d40807..9db7518 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,8 +1,8 @@
 # Oracle driver for Yii Database Change Log
 
-## 1.3.1 under development
+## 2.0.0 under development
 
-- no changes in this release.
+- Enh #255: Implement `SqlParser` and `ExpressionBuilder` driver classes (@Tigrov)
 
 ## 1.3.0 March 21, 2024
 
diff --git a/rector.php b/rector.php
index 7a9f3ac..3435153 100644
--- a/rector.php
+++ b/rector.php
@@ -11,7 +11,10 @@
 return static function (RectorConfig $rectorConfig): void {
     $rectorConfig->paths([
         __DIR__ . '/src',
-        __DIR__ . '/tests',
+        /**
+         * Disabled ./tests directory due to different branches with main package when testing
+         */
+        // __DIR__ . '/tests',
     ]);
 
     // register a single rule
diff --git a/src/Builder/ExpressionBuilder.php b/src/Builder/ExpressionBuilder.php
new file mode 100644
index 0000000..ad38115
--- /dev/null
+++ b/src/Builder/ExpressionBuilder.php
@@ -0,0 +1,16 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Yiisoft\Db\Oracle\Builder;
+
+use Yiisoft\Db\Expression\AbstractExpressionBuilder;
+use Yiisoft\Db\Oracle\SqlParser;
+
+final class ExpressionBuilder extends AbstractExpressionBuilder
+{
+    protected function createSqlParser(string $sql): SqlParser
+    {
+        return new SqlParser($sql);
+    }
+}
diff --git a/src/ColumnSchema.php b/src/ColumnSchema.php
index 6768c49..b0da373 100644
--- a/src/ColumnSchema.php
+++ b/src/ColumnSchema.php
@@ -47,6 +47,7 @@ public function dbTypecast(mixed $value): mixed
             }
 
             if (is_string($value)) {
+                /** @var non-empty-string $placeholder */
                 $placeholder = uniqid('exp_' . preg_replace('/[^a-z0-9]/i', '', $this->getName()));
                 return new Expression('TO_BLOB(UTL_RAW.CAST_TO_RAW(:' . $placeholder . '))', [$placeholder => $value]);
             }
diff --git a/src/DQLQueryBuilder.php b/src/DQLQueryBuilder.php
index c2a95cd..f798ccb 100644
--- a/src/DQLQueryBuilder.php
+++ b/src/DQLQueryBuilder.php
@@ -4,7 +4,9 @@
 
 namespace Yiisoft\Db\Oracle;
 
+use Yiisoft\Db\Expression\Expression;
 use Yiisoft\Db\Expression\ExpressionInterface;
+use Yiisoft\Db\Oracle\Builder\ExpressionBuilder;
 use Yiisoft\Db\Oracle\Builder\InConditionBuilder;
 use Yiisoft\Db\Oracle\Builder\LikeConditionBuilder;
 use Yiisoft\Db\Query\Query;
@@ -87,6 +89,7 @@ protected function defaultExpressionBuilders(): array
             [
                 InCondition::class => InConditionBuilder::class,
                 LikeCondition::class => LikeConditionBuilder::class,
+                Expression::class => ExpressionBuilder::class,
             ],
         );
     }
diff --git a/src/SqlParser.php b/src/SqlParser.php
new file mode 100644
index 0000000..7d03db6
--- /dev/null
+++ b/src/SqlParser.php
@@ -0,0 +1,64 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Yiisoft\Db\Oracle;
+
+use Yiisoft\Db\Syntax\AbstractSqlParser;
+
+final class SqlParser extends AbstractSqlParser
+{
+    public function getNextPlaceholder(int|null &$position = null): string|null
+    {
+        $result = null;
+        $length = $this->length - 1;
+
+        while ($this->position < $length) {
+            $pos = $this->position++;
+
+            match ($this->sql[$pos]) {
+                ':' => ($word = $this->parseWord()) === ''
+                    ? $this->skipChars(':')
+                    : $result = ':' . $word,
+                '"' => $this->skipToAfterChar('"'),
+                "'" => $this->skipQuotedWithoutEscape($this->sql[$pos]),
+                'q', 'Q' => $this->sql[$this->position] === "'"
+                    ? $this->skipQuotedWithQ()
+                    : null,
+                '-' => $this->sql[$this->position] === '-'
+                    ? ++$this->position && $this->skipToAfterChar("\n")
+                    : null,
+                '/' => $this->sql[$this->position] === '*'
+                    ? ++$this->position && $this->skipToAfterString('*/')
+                    : null,
+                default => null,
+            };
+
+            if ($result !== null) {
+                $position = $pos;
+
+                return $result;
+            }
+        }
+
+        return null;
+    }
+
+    /**
+     * Skips quoted string with Q-operator.
+     */
+    private function skipQuotedWithQ(): void
+    {
+        $endChar = match ($this->sql[++$this->position]) {
+            '[' => ']',
+            '<' => '>',
+            '{' => '}',
+            '(' => ')',
+            default => $this->sql[$this->position],
+        };
+
+        ++$this->position;
+
+        $this->skipToAfterString("$endChar'");
+    }
+}
diff --git a/tests/CommandTest.php b/tests/CommandTest.php
index 80c0d44..c973187 100644
--- a/tests/CommandTest.php
+++ b/tests/CommandTest.php
@@ -527,9 +527,10 @@ public function testUpdate(
         array $columns,
         array|string $conditions,
         array $params,
-        string $expected
+        array $expectedValues,
+        int $expectedCount,
     ): void {
-        parent::testUpdate($table, $columns, $conditions, $params, $expected);
+        parent::testUpdate($table, $columns, $conditions, $params, $expectedValues, $expectedCount);
     }
 
     /**
diff --git a/tests/Provider/SqlParserProvider.php b/tests/Provider/SqlParserProvider.php
new file mode 100644
index 0000000..5d7be74
--- /dev/null
+++ b/tests/Provider/SqlParserProvider.php
@@ -0,0 +1,35 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Yiisoft\Db\Oracle\Tests\Provider;
+
+class SqlParserProvider extends \Yiisoft\Db\Tests\Provider\SqlParserProvider
+{
+    public static function getNextPlaceholder(): array
+    {
+        return [
+            ...parent::getNextPlaceholder(),
+            [
+                "name = q'':name'' AND age = :age",
+                ':age',
+                28,
+            ],
+            [
+                "name = Q'':name'' AND age = :age",
+                ':age',
+                28,
+            ],
+            [
+                "name = Q'[:name]' AND age = :age",
+                ':age',
+                28,
+            ],
+            [
+                "name = Q'!':name'!' AND age = :age",
+                ':age',
+                30,
+            ],
+        ];
+    }
+}
diff --git a/tests/QueryBuilderTest.php b/tests/QueryBuilderTest.php
index c4a97ff..e51df70 100644
--- a/tests/QueryBuilderTest.php
+++ b/tests/QueryBuilderTest.php
@@ -612,10 +612,11 @@ public function testUpdate(
         string $table,
         array $columns,
         array|string $condition,
-        string $expectedSQL,
-        array $expectedParams
+        array $params,
+        string $expectedSql,
+        array $expectedParams,
     ): void {
-        parent::testUpdate($table, $columns, $condition, $expectedSQL, $expectedParams);
+        parent::testUpdate($table, $columns, $condition, $params, $expectedSql, $expectedParams);
     }
 
     /**
diff --git a/tests/SqlParserTest.php b/tests/SqlParserTest.php
new file mode 100644
index 0000000..67b2d1c
--- /dev/null
+++ b/tests/SqlParserTest.php
@@ -0,0 +1,25 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Yiisoft\Db\Oracle\Tests;
+
+use Yiisoft\Db\Oracle\SqlParser;
+use Yiisoft\Db\Tests\AbstractSqlParserTest;
+
+/**
+ * @group oracle
+ */
+final class SqlParserTest extends AbstractSqlParserTest
+{
+    protected function createSqlParser(string $sql): SqlParser
+    {
+        return new SqlParser($sql);
+    }
+
+    /** @dataProvider \Yiisoft\Db\Oracle\Tests\Provider\SqlParserProvider::getNextPlaceholder */
+    public function testGetNextPlaceholder(string $sql, string|null $expectedPlaceholder, int|null $expectedPosition): void
+    {
+        parent::testGetNextPlaceholder($sql, $expectedPlaceholder, $expectedPosition);
+    }
+}