Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly Report Disabled Modules #35

Open
sprankhub opened this issue Oct 21, 2022 · 1 comment
Open

Correctly Report Disabled Modules #35

sprankhub opened this issue Oct 21, 2022 · 1 comment

Comments

@sprankhub
Copy link
Contributor

I just got an interesting output with the latest version 2.2.0:

+-------------------------------------+-----------------------------+-------------------------------------+
| Message                             | Group                       | Suggestion                          |
+-------------------------------------+-----------------------------+-------------------------------------+
| No composer dependency found for "" | Missing composer dependency | Current version is . Perhaps use ~? |
+-------------------------------------+-----------------------------+-------------------------------------+

Debugging showed that the module, which was (correctly) detected as a dependency, was disabled in app/etc/config.php. It is correct that the extension checker reports this as an issue, but it should name the module. Should we maybe fall back to the $moduleName here?

@sprankhub sprankhub changed the title Support Escaped Composer Names Correctly Report Disabled Modules Oct 21, 2022
@jissereitsma
Copy link
Contributor

No, I'd rather keep this here as it is, but the message that is outputted is annoying, so I'll just change it there: 7640252

However, the other intruiging part is why modules that are disabled are not detected. The reason is because in many places the core ModuleInfo class only picks up upon enabled modules. But on the other hand, I started to create a class Yireo\ExtensionChecker\Util\OtherModuleInfo (great name) already to overcome this issue. This will require quite some refactoring I guess - too much to quickly do right now. Let's keep this issue open for reminders.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants