Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Idea about a new feature #49

Open
cegento opened this issue Jan 17, 2024 · 2 comments
Open

Idea about a new feature #49

cegento opened this issue Jan 17, 2024 · 2 comments

Comments

@cegento
Copy link
Contributor

cegento commented Jan 17, 2024

Hello,

i wanted to propose the following idea which helps users to only scan modules which they have edited:

A new command (lets say) yireo_extensionchecker:scan:changed which scans every edited module based on the git history

Example:
User A has 3 modules (Catalog Module, EditQuote Module, Coupon Module)
and edited 2 modules (EditQuote Module and Coupon Module)

yireo_extensionchecker:scan:changed would then only scan EditQuote Module and Coupon Module.

A dependency i would recommend is https://github.com/sebastianfeldmann/git (to have a more comfortable access to git in php)

@cegento
Copy link
Contributor Author

cegento commented Feb 8, 2024

hello @jissereitsma, may i ask you what you think about this idea?

@jissereitsma
Copy link
Contributor

I definitely like the idea. However, adding this to the module itself will clutter things with dependencies, while it is not being used for everyone. What about building a separate module for this? This module can have the Git dependency as you say, and it is able to run the same code that ScanCommand is using, or even call the scan command itself via code (https://symfony.com/doc/current/console/calling_commands.html).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants