Skip to content
This repository has been archived by the owner on Jul 1, 2022. It is now read-only.

Remove Open Y Admin & Provide Upgrade Path to Claro #2333

Open
ddrozdik opened this issue Dec 10, 2020 · 8 comments
Open

Remove Open Y Admin & Provide Upgrade Path to Claro #2333

ddrozdik opened this issue Dec 10, 2020 · 8 comments
Assignees
Labels
Level: Middle Needs skilled developer to work on Severity: Minor Backlog Status: Under discussion There is discussion in progress. More information to be provided soon Type: Enhancement Change request. New functionality. Type: Task Maintenance, subtasks

Comments

@ddrozdik
Copy link
Contributor

ddrozdik commented Dec 10, 2020

Environment:
Environment: https://sandboxes-d9.openy.org/
Open Y Type: Custom
Version: 2.7.1

Description:
The latest Drupal 9 Open Y version has no tabs in the admin UI. Without tabs, there is no way to find important pages.
image
(the screenshot was made on the Open Y 2.7.0)

Also, breadcrumbs and action links are missing

@sarah-halby sarah-halby added this to the Drupal 9 milestone Dec 10, 2020
@podarok
Copy link
Contributor

podarok commented Dec 11, 2020

Hi, @ddrozdik
We have Claro theme in Drupal 9
Tabs are in place
image
it was recently fixed by core and tracked in #2168

I don't think we will have the bandwidth to support all themes for Admin UI - I see you are using the Seven theme.
@sarah-halby was testing of the Seven theme included in the QA scope?

@podarok podarok added Status: Under discussion There is discussion in progress. More information to be provided soon Status: Won't fix Works as designed or no resources to work on. Low priority, high effort tasks. labels Dec 11, 2020
@ddrozdik
Copy link
Contributor Author

@podarok in our tests we were using the Open Y Admin theme since Claro a bit unstable. But if the Open Y team is going to switch from the Open Y Admin theme to Claro we will need to mark it as deprecated or even delete it from the core.

@podarok
Copy link
Contributor

podarok commented Dec 11, 2020

Yes, for sure we'll deprecate Seven, due to it was developed for Drupal 8 ( even the description says that ).
Here is the communication we had about Claro will be default in Drupal 9. https://openy.slack.com/archives/C6G4ZTLVC/p1599231092155400

Regarding unstable - feel free to share any bugs and concerns for Claro.
The decision was made due to Claro is way more accessible and mobile-friendly than Seven.

Thank you.

As a comment regarding the Seven theme
I've switched to Seven on a sandbox and found tabs in place
image
Could you verify on your end?

@ddrozdik
Copy link
Contributor Author

@podarok I confirm tabs are in place for the Seven theme, however in the Open Y Admin, as I mentioned above, tabs are missing.
image

But as I see Open Y Admin theme is not used as a default admin theme, so I guess we can ignore this issue and close it.

By the way, do we need an Open Y Admin theme then?

@ddrozdik
Copy link
Contributor Author

@podarok Take a look at this theme https://www.drupal.org/project/gin it was built on the foundation of Claro from one of the lead designers of Claro & Drupal Design System. It is still alpha however looks very promising.

@sarah-halby sarah-halby added the Type: Task Maintenance, subtasks label Dec 15, 2020
@sarah-halby
Copy link
Collaborator

Task: remove Open Y Admin Theme & provide upgrade path in the documentation before closing this issue.

@podarok
Copy link
Contributor

podarok commented Dec 17, 2020

@ddrozdik thank you for the gin theme suggestion. Our goal is to provide 99% maintenance stability and Claro looks more reliable because supported by Drupal core. Adding a dependency to contrib theme - possible, but we should have more demand, I guess
/cc @sarah-halby

@sarah-halby sarah-halby changed the title Tabs are missing in Admin UI Remove Open Y Admin & Provide Upgrade Path to Claro Dec 22, 2020
@sarah-halby sarah-halby added Severity: Minor Backlog Type: Enhancement Change request. New functionality. Level: Middle Needs skilled developer to work on and removed Status: Won't fix Works as designed or no resources to work on. Low priority, high effort tasks. labels Dec 22, 2020
@sarah-halby
Copy link
Collaborator

Update: to include in February 2021 release or beyond. Notes: we can stay as-is - for associations that use seven for the admin interface, they can keep using it. For new installations, Claro will be the default. If we provide documentation, then the upgrade path will be Claro and there will be a UI change for content managers.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Level: Middle Needs skilled developer to work on Severity: Minor Backlog Status: Under discussion There is discussion in progress. More information to be provided soon Type: Enhancement Change request. New functionality. Type: Task Maintenance, subtasks
Projects
None yet
Development

No branches or pull requests

3 participants