Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug - custom_header broke nuclei and ffuf #950

Closed
psyray opened this issue Sep 12, 2023 · 3 comments
Closed

Bug - custom_header broke nuclei and ffuf #950

psyray opened this issue Sep 12, 2023 · 3 comments

Comments

@psyray
Copy link
Contributor

psyray commented Sep 12, 2023

@yogeshojha
This bug #651 is still present although you mentioned it was fixed in this commit aa171c2

It seems that you only resolve the httpx part of this bug

After investigating it seems the split function break the command due to the comma contained in the -H args.
When you use logger.info(subprocess.list2cmdline(command.split())) you can see that the " are escaped
image

It could be easily fix using os.system like you do for httpx, but it's a quick and dirty fix

Maybe this solution is the best
https://stackoverflow.com/a/14928914

Using the list form of invocation, eg in the SO post

command = ["ffmpeg", "-i", "concat:1.ts|2.ts", "-vcodec", "copy", "-acodec", "copy", "temp.mp4"]
output,error  = subprocess.Popen(command)
@github-actions
Copy link
Contributor

👋 Hi @psyray,
Issues is only for reporting a bug/feature request. Please read documentation before raising an issue https://rengine.wiki
For very limited support, questions, and discussions, please join reNgine Discord channel: https://discord.gg/azv6fzhNCE
Please include all the requested and relevant information when opening a bug report. Improper reports will be closed without any response.

@psyray
Copy link
Contributor Author

psyray commented Sep 12, 2023

Fixed with #951
Tested & working

@psyray
Copy link
Contributor Author

psyray commented Nov 18, 2023

Fixed in v2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant