Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug - Depreciated Selenium methods API IPToDomain #959

Closed
fish-not-phish opened this issue Sep 25, 2023 · 2 comments
Closed

Bug - Depreciated Selenium methods API IPToDomain #959

fish-not-phish opened this issue Sep 25, 2023 · 2 comments

Comments

@fish-not-phish
Copy link

fish-not-phish commented Sep 25, 2023

Found a bug? Please fill out the sections below. 👍 Please do not use this to raise any support requests, instead join our discord channel #support for support requests.

Issue Summary

Rengine is using depreciated Selenium functions.

Within the IPToDomain function inside of the API application, the developer is utilizing methods called "find_elements_by_xpath" and "find_element_by_xpath". These methods were deprecated by Selenium and was replaced with:

find_elements("xpath", "path_needed")
find_element("xpath", "path_needed")

Because of this, the web application produces a 500 server error due to using non-existent Selenium methods. This API function still does not work (for unknown reasons to me), but I wanted to point out that these methods should be updated within the source code and this function should likely be reviewed. I tested in an isolated environment with the old depreciated methods "find_elements_by_xpath" and "find_element_by_xpath" and Selenium will not run. However, replacing it works when replaced with the newer methods.

Steps to Reproduce

  1. Add Targets
  2. Specifically, add an IP or IP block
  3. Submit
  4. Server 500 error is returned
  • I have confirmed that this issue can be reproduced as described on a latest version/pull of reNgine: Yes

Technical details

Tested in a clean install of Kali as well as a clean install of Ubuntu.

I would be happy to troubleshoot this if I could be directed on how to produce logging output. The API does not appear to be an app in the INSTALLED_APPS, so I cannot make a logger for it within Django. How might I setup a logger or a form of output to troubleshoot this myself. All my attempts to add loggers resulted in crashing the application.

@github-actions
Copy link
Contributor

👋 Hi @fish-not-phish,
Issues is only for reporting a bug/feature request. Please read documentation before raising an issue https://rengine.wiki
For very limited support, questions, and discussions, please join reNgine Discord channel: https://discord.gg/azv6fzhNCE
Please include all the requested and relevant information when opening a bug report. Improper reports will be closed without any response.

@psyray
Copy link
Contributor

psyray commented Nov 18, 2023

Check in v2 and open a new issue if it persists
This part has been completely rewritten

@psyray psyray closed this as completed Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants