Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metrics related to watch stream #984

Closed
hackerwins opened this issue Aug 27, 2024 · 1 comment
Closed

Add metrics related to watch stream #984

hackerwins opened this issue Aug 27, 2024 · 1 comment
Assignees
Labels
enhancement 🌟 New feature or request

Comments

@hackerwins
Copy link
Member

hackerwins commented Aug 27, 2024

Description:

Currently, Server collects metrics using Prometheus, aggregating changes, operations, and snapshot storage during synchronization(PushPull API). To enhance real-time collaboration features, we propose the addition of the following metrics:

A. Count of Connections

  • Purpose: To understand the real-time usage of the service.
  • Benefit: This would allow for accurate measurement of real-time collaboration feature usage and better prediction of system load.

B. Event Exchange Size

  • Purpose: To monitor the quantity and size of events exchanged through the stream.
  • Benefit: This would help optimize network bandwidth usage and improve performance in large collaboration sessions.

Also, if watch stream-related metrics are aggregated by project, it is useful to show graphs on the dashboard later.

Related to yorkie-team/dashboard#162

Why:

With these enhancements, we can better monitor the usage and performance of real-time collaboration features, leading to improved service quality and user experience.

@hackerwins
Copy link
Member Author

@emplam27 Would you like to try to tackle this issue?

emplam27 added a commit that referenced this issue Sep 4, 2024
Added count of watch document connection Metrics.
the count is increased when client watch document, and decreased when client unwatch document
emplam27 added a commit that referenced this issue Sep 5, 2024
Added count of watch document connection Metrics.
the count is increased when client watch document, and decreased when client unwatch document
@devleejb devleejb moved this from Backlog to In progress in Yorkie Project - 2024 Sep 6, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in Yorkie Project - 2024 Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🌟 New feature or request
Projects
Status: Done
Development

No branches or pull requests

2 participants