Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional checks tbump could perform #113

Open
dmerejkowsky opened this issue Sep 3, 2021 · 1 comment
Open

Additional checks tbump could perform #113

dmerejkowsky opened this issue Sep 3, 2021 · 1 comment
Labels
good first issue

Comments

@dmerejkowsky
Copy link
Collaborator

dmerejkowsky commented Sep 3, 2021 •
edited
Loading

  • Check that new_version is different than previous_version
  • Check that at least one file changes

This means we'll always have a diff and that git commit will not fail later on because the git diff will never be empty
@slashformotion
Copy link
Contributor

I am not sure why tbump should check if one file changed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dmerejkowsky @slashformotion