Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Idea: Pass in commandline config from pyproject.toml #143

Open
Rowlando13 opened this issue Aug 1, 2022 · 5 comments
Open

Idea: Pass in commandline config from pyproject.toml #143

Rowlando13 opened this issue Aug 1, 2022 · 5 comments

Comments

@Rowlando13
Copy link
Contributor

This is a super great project! I think it is a really clean rewrite of bumpversion. It is also really nice to have support for pyproject.toml. These days there are so many configuration files.
It would be nice to be able to pass in command line arguments in the pyproject.toml file. I think you could do it nicely if you had a [tool.tbump.options] heading. Then you could pass in something like patch-only = true .
It does not look too hard. I could add it if you are interested.

@dmerejkowsky
Copy link
Collaborator

Please do :)

@Rowlando13
Copy link
Contributor Author

Got it.

@Rowlando13
Copy link
Contributor Author

I don't use poetry. I installed dev dependencies using pip by looking at your pyproject and manually typing them into pip. Do you know of a better way? I can add it to your README for future contributors.

@Rowlando13
Copy link
Contributor Author

So... I made a mistake about the ease of adding to the codebase. You project is much more complex than I initially thought. I made some minor documentation updates instead. Thanks again for the project.

@dmerejkowsky
Copy link
Collaborator

You project is much more complex than I initially thought.

It seems we need to either document and/or improve the current architecture - you're not the first person to find the project hard to patch ...

But this is still a valid feature request - re-opening

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants