sslh-fork stops servicing requests when connection is closed before accept()

[xieliwei]

I've recently updated sslh and it does not survive for more than a few hours before requiring a restart. Digging into what's happening, it seems that sslh-fork is too strict in handling error-ed accepts():

sslh/sslh-fork.c

Lines 186 to 187 in 710807f

	in_socket = accept(endpoint[active_endpoint].socketfd, 0, 0);
	CHECK_RES_RETURN(in_socket, "accept", /*void*/ );

This led me to a closed pull request #421 and a commit (3117c15) mentioned in its code review.

The commit is odd though, as it is doing exactly the wrong thing the code review mentioned. The committed code can never be reached because CHECK_RES_RETURN(in_socket, "accept", /*void*/ ); would return when in_socket == -1:

sslh/sslh-fork.c

Lines 186 to 189 in 710807f

	in_socket = accept(endpoint[active_endpoint].socketfd, 0, 0);
	CHECK_RES_RETURN(in_socket, "accept", /*void*/ );
	if (in_socket == -1) {
	print_message(msg_system_error, "%s:%d:%s:%d:%s\n",

Could it be that the commit intended to remove the CHECK_RES_RETURN() as well?