Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mypy failure: unused error code in numpy2_compat.py #5100

Closed
chrishavlin opened this issue Jan 23, 2025 · 0 comments · Fixed by #5101
Closed

mypy failure: unused error code in numpy2_compat.py #5100

chrishavlin opened this issue Jan 23, 2025 · 0 comments · Fixed by #5101
Labels
infrastructure Related to CI, versioning, websites, organizational issues, etc

Comments

@chrishavlin
Copy link
Contributor

after merging with main just now, #4996 is failing the type-check test with an unrelated failure (link):

yt/_maintenance/numpy2_compat.py:9: error: Unused "type: ignore" comment  [unused-ignore]
yt/_maintenance/numpy2_compat.py:9: error: Incompatible types in assignment (expression has type "Callable[[_Buffer | _SupportsArray[dtype[Any]] | _NestedSequence[_SupportsArray[dtype[Any]]] | builtins.bool | int | float | complex | str | bytes | _NestedSequence[builtins.bool | int | float | complex | str | bytes], _Buffer | _SupportsArray[dtype[Any]] | _NestedSequence[_SupportsArray[dtype[Any]]] | builtins.bool | int | float | complex | str | bytes | _NestedSequence[builtins.bool | int | float | complex | str | bytes] | None, float, int], generic[Any] | ndarray[tuple[int, ...], dtype[generic[Any]]]]", variable has type overloaded function)  [assignment]
yt/_maintenance/numpy2_compat.py:9: note: Error code "assignment" not covered by "type: ignore" comment
Found 2 errors in 1 file (checked 516 source files)
@chrishavlin chrishavlin added the infrastructure Related to CI, versioning, websites, organizational issues, etc label Jan 23, 2025
@chrishavlin chrishavlin changed the title mypy failure mypy failure: unused error code in numpy2_compat.py Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Related to CI, versioning, websites, organizational issues, etc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant