Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop move base launcher in yocs_navigator #64

Open
bit-pirate opened this issue Nov 22, 2014 · 3 comments
Open

drop move base launcher in yocs_navigator #64

bit-pirate opened this issue Nov 22, 2014 · 3 comments

Comments

@bit-pirate
Copy link
Contributor

To properly support yocs_navigator/navigator.launch
we would need to add move_base and turtlebot dependencies, which would blow up this light-weight package.

if this launcher is used, then I suggest to move it to where it is used (what it is used with), e.g. turtlebot.

@jihoonl
Copy link
Collaborator

jihoonl commented Nov 24, 2014

It was to reduce my headache to make internal launch convenient. I still think it is good to keep it here.

Instead, we can replace these params to free the turtlebot_dependency.

@bit-pirate
Copy link
Contributor Author

What is "internal launch"? If you are using this launcher inside larger launchers, e.g. for turtlebot, waiterbot, then please add move_base, velocity smoother etc. there.

@jihoonl
Copy link
Collaborator

jihoonl commented Nov 29, 2014

Can you explain what benefits are there not to keep them in the package?
I kept them in the package for these reasons.

  • don't want to keep the same launch files for every robot with small configuration changes.
  • move_base and vel_smoother are used for all of our robots anyway.

It is possible to keep move_base and vel_smoother for every robot. But I kept them for these convenient reasons. Also I don't think it badly hurting dependencies since these modules are mostly required for all of our robots anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants