Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What are onMoveLineUp and onMoveLineDown for? (Remapping editor.action.moveLines*Action...) #1459

Open
leoauri opened this issue Aug 19, 2024 · 1 comment
Labels
Area: List editing List editing: continuation, numbering, toggling, etc. Issue: Question

Comments

@leoauri
Copy link

leoauri commented Aug 19, 2024

function onMoveLineUp() {

"command": "markdown.extension.onMoveLineUp",

Hi there,
I want to remap editor.action.moveLinesUpAction and editor.action.moveLinesDownAction. I see there are some strange onMoveLine* commands in this extension, mapped to the defaults for editor.action.moveLines*Action. Do I have to manually remap them as well to the new keys?

@yzhang-gh
Copy link
Owner

Hi, they are used to fix the list markers (1, 2, 3, ...) when you edit a ordered list (specifially moving lines up or down). In other cases (i.e. not in a Markdown ordered list), they should just do the same as the original moveLinesUp/DownAction.

@yzhang-gh yzhang-gh added Issue: Question Area: List editing List editing: continuation, numbering, toggling, etc. labels Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: List editing List editing: continuation, numbering, toggling, etc. Issue: Question
Projects
None yet
Development

No branches or pull requests

2 participants