Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color of ticked tasks is hard to see #192

Closed
Splike opened this issue May 31, 2018 · 7 comments
Closed

Color of ticked tasks is hard to see #192

Splike opened this issue May 31, 2018 · 7 comments
Labels
Area: Styles and Presentation Pertaining to the display of HTML (rendered form of Markdown). Generally, out of our control! Area: Task list GitHub Flavored Markdown task list. Issue: Question Res: External Outside of our control/codebase.

Comments

@Splike
Copy link

Splike commented May 31, 2018

The check-mark color of completed tasks is too close the the actual color of the check-mark box. Is it possible to tweak the check-mark color, so there is more contrast and therefore easier to see when something is checked off?

@yzhang-gh
Copy link
Owner

yzhang-gh commented May 31, 2018

The checkbox control is implemented by the browser. And it will be rendered differently in different browsers. I am afraid we cannot change its style easily.

VSCode (-> Electron -> Chromium)

image

Microsoft Edge

image

@Splike
Copy link
Author

Splike commented May 31, 2018

Oh, that's a shame. The faded out grey colors simply don't work very will :(

@Lemmingh Lemmingh added Area: Task list GitHub Flavored Markdown task list. Area: Styles and Presentation Pertaining to the display of HTML (rendered form of Markdown). Generally, out of our control! Issue: Question Res: External Outside of our control/codebase. labels Aug 24, 2021
@JamesO2x
Copy link

JamesO2x commented Mar 8, 2022

Hi, I know this issue is marked as closed, but I'm having the exact same issue.

There's another extension that just creates colored checkboxes in MarkDown preview, but it unfortunately causes conflict with this extension.

I made a post about it there, and I actually thought I was having issue with that person's extension when it was actually this one. You can see the thread here: mjbvz/vscode-markdown-checkboxes#13

If you install that extension, it will turn completed Checkboxes blue (but only if you disable this extension first). So having the checkboxes colored is definitely possible.

@Lemmingh
Copy link
Collaborator

Lemmingh commented Mar 9, 2022

Matt Bierner's bierner.markdown-checkbox renders checkboxes as "enabled <input> elements", while ours produces "disabled elements".

As mentioned above, it's the web browser (Chromium) that decides how to present the enabled-disabled state. We CANNOT control it.

@JamesO2x
Copy link

Ah, that makes sense. How can I modify the extension to render Enabled input elements instead then? That seems like a pretty straightforward solution.

@yzhang-gh
Copy link
Owner

There was a PR #962 but didn't get merged.

As a workaround, you can open ~/.vscode/extensions/yzhang.markdown-all-in-one-xxx/dist/extension.js and change

e.use(n(11))

to

e.use(n(11), {enabled: true})

Reload VS Code and the checkboxes will be enabled.

@JamesO2x
Copy link

Thank you so much! This is exactly what I was looking for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Styles and Presentation Pertaining to the display of HTML (rendered form of Markdown). Generally, out of our control! Area: Task list GitHub Flavored Markdown task list. Issue: Question Res: External Outside of our control/codebase.
Projects
None yet
Development

No branches or pull requests

4 participants