Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependence on command-line tools #34

Open
za3k opened this issue Sep 22, 2022 · 2 comments
Open

Remove dependence on command-line tools #34

za3k opened this issue Sep 22, 2022 · 2 comments
Labels
enhancement New feature or request
Milestone

Comments

@za3k
Copy link
Owner

za3k commented Sep 22, 2022

Remove dependencies on all command-line tools:

@za3k za3k added this to the v1.2 milestone Sep 22, 2022
@za3k za3k added the enhancement New feature or request label Sep 22, 2022
@anarcat
Copy link
Contributor

anarcat commented Mar 3, 2023

(which)

i've looked at this in the code and i think the proper way to do this is simply not check if the program is present and try to execute it directly. you will get an error and then you handle that appropriately.

i was about to go on and do this, but there's calls like this everywhere in the code and I wanted to make sure that made sense for you before going ahead. :)

@za3k
Copy link
Owner Author

za3k commented Mar 3, 2023

I'm wasn't planning to remove dependence on which. The reason being, if I just remove dependency on all the other command-line tools, the which dependency disappears automatically.

That said if you give me a PR I'd accept it.

Edit: I still want to fail-fast for the new version, so make sure to preserve that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants