Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zincr dismissed an approval of an employee in a contributor's PR #31

Open
nolar opened this issue Jul 8, 2019 · 1 comment
Open

Zincr dismissed an approval of an employee in a contributor's PR #31

nolar opened this issue Jul 8, 2019 · 1 comment

Comments

@nolar
Copy link

nolar commented Jul 8, 2019

Zincr dismisses an approval added by an org member to a PR, once that organisation member adds a commit to the PR (but they are not the PR opener).

This behaviour is counter-intuitive:

  1. If an org member opens a PR, their voice is already counted as +1, and required only 1 extra approval from another org member.

  2. If an external contributor opens a PR, 2 org member approvals are needed. 1 is usually mine, 1 extra.

  3. If an external contributor opens a PR, and an org member (me) adds a commit to that PR, that member's approval is dismissed and not counted, requiring 2 extra org member approvals.

Point 3 goes against logic of points 1 & 2: if the org member is automatically counted as 1 approval in their own PRs, why shouldn't it be accepted in contributors' PRs?

Example PR: zalando-incubator/kopf#114 — here, Zincr dismissed an approval of user "nolar" when user "nolar" added a commit. In all other PRs, "nolar" was normally approving the changes (and not adding the commits).

image

@nolar
Copy link
Author

nolar commented Jul 8, 2019

Probably related: #17

@nolar nolar changed the title Zincr dismissed the approval of an employee in third-party PRs Zincr dismissed an approval of an employee in a contributor's PR Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant