You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Zincr dismisses an approval added by an org member to a PR, once that organisation member adds a commit to the PR (but they are not the PR opener).
This behaviour is counter-intuitive:
If an org member opens a PR, their voice is already counted as +1, and required only 1 extra approval from another org member.
If an external contributor opens a PR, 2 org member approvals are needed. 1 is usually mine, 1 extra.
If an external contributor opens a PR, and an org member (me) adds a commit to that PR, that member's approval is dismissed and not counted, requiring 2 extra org member approvals.
Point 3 goes against logic of points 1 & 2: if the org member is automatically counted as 1 approval in their own PRs, why shouldn't it be accepted in contributors' PRs?
Example PR: zalando-incubator/kopf#114 — here, Zincr dismissed an approval of user "nolar" when user "nolar" added a commit. In all other PRs, "nolar" was normally approving the changes (and not adding the commits).
The text was updated successfully, but these errors were encountered:
nolar
changed the title
Zincr dismissed the approval of an employee in third-party PRs
Zincr dismissed an approval of an employee in a contributor's PR
Jul 8, 2019
Zincr dismisses an approval added by an org member to a PR, once that organisation member adds a commit to the PR (but they are not the PR opener).
This behaviour is counter-intuitive:
If an org member opens a PR, their voice is already counted as +1, and required only 1 extra approval from another org member.
If an external contributor opens a PR, 2 org member approvals are needed. 1 is usually mine, 1 extra.
If an external contributor opens a PR, and an org member (me) adds a commit to that PR, that member's approval is dismissed and not counted, requiring 2 extra org member approvals.
Point 3 goes against logic of points 1 & 2: if the org member is automatically counted as 1 approval in their own PRs, why shouldn't it be accepted in contributors' PRs?
Example PR: zalando-incubator/kopf#114 — here, Zincr dismissed an approval of user "nolar" when user "nolar" added a commit. In all other PRs, "nolar" was normally approving the changes (and not adding the commits).
The text was updated successfully, but these errors were encountered: