Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Remove support for legacy logging #3546

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

mkcp
Copy link
Contributor

@mkcp mkcp commented Feb 26, 2025

Description

WIP: two major categories of work to finish here:
1: Fully log-format="legacy" while ensuring message is still set up properly to print non-log messages like Yaml and tables.
2: Chase down every message log statement, spinner, and progress bar in the main zarf codebase. This involves a bunch of changes in packager(1) but should be a net-zero change in behavior for any user not running --log-format=legacy.

The plan is: get it compiling, then rip out the CLI layer, then chase down remaining logs and any debug coverage we might have missed the first go around.

TODO: Document and flag all breaking changes.

Related Issue

Fixes #3500
Relates to #2576

Checklist before merging

Copy link

netlify bot commented Feb 26, 2025

Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit 97c89fa
🔍 Latest deploy log https://app.netlify.com/sites/zarf-docs/deploys/67bfc2bcbb31c100086de5fe

Copy link

codecov bot commented Feb 26, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 16 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/internal/packager/helm/chart.go 20.00% 4 Missing ⚠️
src/pkg/layout/component.go 0.00% 4 Missing ⚠️
src/internal/packager/helm/destroy.go 0.00% 2 Missing ⚠️
src/internal/packager/helm/zarf.go 0.00% 1 Missing ⚠️
src/internal/packager/template/template.go 0.00% 1 Missing ⚠️
src/internal/packager2/layout/oci.go 0.00% 1 Missing ⚠️
src/pkg/packager/remove.go 0.00% 1 Missing ⚠️
src/pkg/packager/sources/oci.go 0.00% 1 Missing ⚠️
src/pkg/packager/sources/tarball.go 0.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
src/cmd/connect.go 36.47% <ø> (+2.40%) ⬆️
src/cmd/package.go 43.14% <100.00%> (+0.27%) ⬆️
src/cmd/root.go 38.34% <100.00%> (+12.75%) ⬆️
src/cmd/viper.go 53.08% <ø> (ø)
src/internal/packager/helm/utils.go 81.63% <100.00%> (+6.63%) ⬆️
src/pkg/logger/logger.go 55.33% <100.00%> (+1.55%) ⬆️
src/pkg/zoci/common.go 83.33% <100.00%> (+11.90%) ⬆️
src/internal/packager/helm/zarf.go 0.00% <0.00%> (ø)
src/internal/packager/template/template.go 11.22% <0.00%> (+0.33%) ⬆️
src/internal/packager2/layout/oci.go 23.15% <0.00%> (+0.70%) ⬆️
... and 6 more

@mkcp mkcp changed the title WIP Remove message logging support WIP Remove support for legacy logging Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Complete deprecation of Message
1 participant