Encapsulate nicegui.js #3007
falkoschindler
started this conversation in
Ideas / Feature Requests
Replies: 1 comment 1 reply
-
I've made a start here. A few manual tests and it looks fine, but I'm still figuring out the selenium tests before I put in a PR. |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
As noticed by @nigelsim in #2984 (reply in thread), nicegui.js currently populates the global
window
scope, which can lead to conflicts with other JavaScript code like browser extensions.Even though I like the idea of wrapping nicegui.js in something like
we need to expose some of the functions like
parseElements
orcreateApp
which are used in index.html.Maybe we can implement nicegui.js as a module, exporting individual functions?
And maybe we can use bundlers like webpack or rollup to even further improve nicegui.js, e.g. by minifying the code or by bundling with Vue, Quasar and Tailwind?
Any help would be greatly appreciated, as this is not our primary area of expertise.
Beta Was this translation helpful? Give feedback.
All reactions