Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transparent input details should be retrieved with transactions on account recovery #1074

Closed
AArnott opened this issue Dec 24, 2023 · 4 comments

Comments

@AArnott
Copy link
Contributor

AArnott commented Dec 24, 2023

When downloading a transaction that includes transparent inputs, the details of the transparent inputs must be downloaded as well so that the transaction amounts and fees can be correctly calculated.

See brief discussion on discord.

Note this is not just for account recovery scenarios. It could be that the account is already fully downloaded, but another instance of that same account exists on another app or device and the transaction was created there, so really any time the transaction is downloaded rather than created locally, these details should download.

@AArnott
Copy link
Contributor Author

AArnott commented Dec 24, 2023

This is necessary for reliably computing fees, as @nuttycom described in this discord conversation.

@nuttycom
Copy link
Contributor

Related to #1361

@nuttycom nuttycom added this to the Zcashd wallet replacement milestone Apr 23, 2024
@AArnott
Copy link
Contributor Author

AArnott commented Apr 24, 2024

Incidentally, I've implemented this myself in the sync code I built on top of librustzcash. Let me know if you're interested.

@nuttycom
Copy link
Contributor

nuttycom commented Sep 4, 2024

Fixed in #1473

@nuttycom nuttycom closed this as completed Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants