Compilation error when compiling webrtc-sys (from zed-industries/livekit-rust-sdks clone)

[gim913]

This isn't really a bug report, but maybe it'll save someone else's time.

When trying to compile zed on windows I had a problem with webrtc-sys, the error reported looked something like this:

C:\Program Files (x86)\Windows Kits\10\include\10.0.22000.0\um\fileapi.h(1065): error C2061: syntax error: identifier 'FILE_INFO_BY_HANDLE_CLASS'
  C:\Program Files (x86)\Windows Kits\10\include\10.0.22000.0\um\winbase.h(9162): error C2061: syntax error: identifier 'FILE_INFO_BY_HANDLE_CLASS'

Building instructions mention explicitly:

Install Windows 11 or 10 SDK depending on your system, but ensure that at least Windows 10 SDK version 2104 (10.0.20348.0) is installed on your machine. You can download it from the Windows SDK Archive

The SDK was installed via VS 2019 installer and at the time of reporting this issue, it is latest SDK that VS 2019 installer provides.

As you can see sdk version seems to be higher then the one mentioned in the docs.

The cause of this issue is that:

• somehow webrtc.ninja contains -DNTDDI_VERSION=NTDDI_WIN10_NI in defines
• but last versions that sdkddver.h in sdk 10.0.22000.0 contains are:

  #define NTDDI_WIN10_VB                      0x0A000008
  #define NTDDI_WIN10_MN                      0x0A000009
  #define NTDDI_WIN10_FE                      0x0A00000A
  #define NTDDI_WIN10_CO                      0x0A00000B
  

• inside minwinbase.h, there's condition around FILE_INFO_BY_HANDLE_CLASS enum: #if (NTDDI_VERSION >= NTDDI_LONGHORN) - because there's no value for NTDDI_WIN10_NI, this condition is not fulfilled and compilation fails.

Somebody else figured similar issue here: microsoft/Windows-classic-samples#317 (comment)

So the way I fixed this, is by going straight to SDK page (which is already linked in the docs) and installed SDK from there, that SDK is 10.0.26100.0 and webrtc-sys and zed itself compiled fine.

Zed Version and System Specs

main branch, commit ID 5d005a7

[dvorakchen]

In my case, it was network issue. Try VPN.

[gim913]

As noted at the bottom, it eventually worked, although given the circumstances, I'm not sure which version of Windows SDK should be mentioned in the documentation.