Separate theme_overrides settings for dark and light mode

[jannisborgers]

I have this in my settings.json:

{
"theme": {
    "mode": "system",
    "light": "Catppuccin Latte",
    "dark": "Palenight Theme"
  },
  "experimental.theme_overrides": {
    "editor.foreground": "#6A718A",
  }
}

theme_overrides override both dark and light themes. In the case above, editor.foreground is way too dark against the editor background from the Palenight theme, which activates with dark mode via the system. I have a lot of other overrides for UI elements and syntax that I tuned for my needs in the light theme, which simply don’t work in the dark theme.

It would be helpful if the overrides could be defined for all, light and dark separately, where values in light or dark take precedence over values in all:

{
"theme": {
    "mode": "system",
    "light": "Catppuccin Latte",
    "dark": "Palenight Theme"
  },
  "experimental.theme_overrides": {
    "all": {
      "modified": "#275fe4",
      "syntax": {
        "property": {
          "color": "#000"
        }
      }
    },
    "light": {
      "editor.foreground": "#6A718A",
      "syntax": {
        "property": {
          "color": "#6A718A" // takes precedence
        }
      }
    },
    "dark": {
      "panel.background": "#6A718A",
      "modified": "#275fe4", // takes precedence
     }
  }
}

Note that this is different from per-project themes or per-filetype theme overrides (which would also be very cool to see), so if all three see the light of day, complexity concerning precedence is added.