Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing field in themes JSON Schema #21335

Closed
1 task done
bobuk opened this issue Nov 29, 2024 · 1 comment · Fixed by #21428
Closed
1 task done

Missing field in themes JSON Schema #21335

bobuk opened this issue Nov 29, 2024 · 1 comment · Fixed by #21428
Labels
duplicate Additional reports of an existing issue

Comments

@bobuk
Copy link

bobuk commented Nov 29, 2024

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

Zed's json schema said that there's only three properties in HighlightStyleContent: color, font_style and font_weight. in the code there's also a background_color that is really important for nice themes like FlatWhite.

Environment

Zed: v0.164.0 (Zed Preview)
OS: macOS 15.1.0
Memory: 128 GiB
Architecture: aarch64

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your Zed.log file to this issue.

Zed.log
@bobuk bobuk added admin read Pending admin review bug [core label] triage Maintainer needs to classify the issue labels Nov 29, 2024
@notpeter
Copy link
Member

notpeter commented Dec 2, 2024

Duplicate of:

@notpeter notpeter closed this as completed Dec 2, 2024
@notpeter notpeter added duplicate Additional reports of an existing issue and removed bug [core label] triage Maintainer needs to classify the issue admin read Pending admin review labels Dec 2, 2024
@notpeter notpeter mentioned this issue Dec 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate Additional reports of an existing issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Publish theme json schema v0.2.0 zed-industries/zed
2 participants
@bobuk @notpeter