Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python syntax highlighting regression #25803

Open
drcongo opened this issue Feb 28, 2025 · 1 comment · May be fixed by #25813
Open

Python syntax highlighting regression #25803

drcongo opened this issue Feb 28, 2025 · 1 comment · May be fixed by #25813
Labels
python Python programming language support tree-sitter Syntax highlighting and tree-sitter

Comments

@drcongo
Copy link

drcongo commented Feb 28, 2025

Summary

The PR at #25331 seems to have broken a fair bit of the Python syntax highlighting.

Actual Behavior:

Image
Image

The constants should be highlighted the same way as the null is in the settings. this was working before the PR at #25331

Expected Behavior:

Image

I think it may have broken more than just the constants too but I'm struggling to remember how close I'd got my Zed theme to my Sublime theme before the update. There's more reported here.

Worth mentioning too that my theme is fully up to date with the latest changes to the schema in #25323

Zed Version and System Specs

Zed: v0.176.1 (Zed Preview)
OS: macOS 15.3.1
Memory: 32 GiB
Architecture: aarch64

@devzeth devzeth added tree-sitter Syntax highlighting and tree-sitter python Python programming language support labels Feb 28, 2025
@MrSubidubi MrSubidubi linked a pull request Feb 28, 2025 that will close this issue
@failable
Copy link

Find lots of cases of that, not sure any of them is intentional.

I noticed this after this week's preview update and I found I 'lose' lost of colors at least in the one-light theme.

Types

Image

but

Image

Global variable and constants

Image Image

Enum class (OP)

Image

Enum variants

Image

Imports

Image

All of them are highlighted before. So just not sure if this is a intentional 'fix' in his week. If yes, I am OK with it.

Originally posted by @failable in #25709

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Python programming language support tree-sitter Syntax highlighting and tree-sitter
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants