Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ruby 3 support #1

Closed
zedtux opened this issue Sep 17, 2022 · 2 comments
Closed

Ruby 3 support #1

zedtux opened this issue Sep 17, 2022 · 2 comments
Assignees
@zedtux

Comments

@zedtux
Copy link
Owner

zedtux commented Sep 17, 2022

The gem breaks with Ruby 3 :

           +cucumber | wrong number of arguments (given 1, expected 0) (ArgumentError)
           +cucumber | /usr/local/bundle/gems/database_cleaner-nobrainer-1.0.0/lib/database_cleaner/nobrainer/deletion.rb:8:in `initialize'
           +cucumber | /usr/local/bundle/gems/database_cleaner-core-2.0.1/lib/database_cleaner/cleaner.rb:85:in `new'
           +cucumber | /usr/local/bundle/gems/database_cleaner-core-2.0.1/lib/database_cleaner/cleaner.rb:85:in `create_strategy'
           +cucumber | /usr/local/bundle/gems/database_cleaner-core-2.0.1/lib/database_cleaner/cleaner.rb:45:in `strategy='
           +cucumber | /usr/local/bundle/gems/database_cleaner-core-2.0.1/lib/database_cleaner/cleaners.rb:17:in `block in strategy='
           +cucumber | /usr/local/bundle/gems/database_cleaner-core-2.0.1/lib/database_cleaner/cleaners.rb:17:in `each'
           +cucumber | /usr/local/bundle/gems/database_cleaner-core-2.0.1/lib/database_cleaner/cleaners.rb:17:in `strategy='
           +cucumber | /usr/local/lib/ruby/3.0.0/forwardable.rb:233:in `strategy='
           +cucumber | /application/features/support/database_cleaner.rb:7:in `<main>'
@zedtux zedtux self-assigned this Sep 17, 2022
@zedtux
Copy link
Owner Author

zedtux commented Sep 29, 2022

Should be related to DatabaseCleaner/database_cleaner#677

@zedtux
Copy link
Owner Author

zedtux commented Dec 31, 2022

With Ruby 2.7, the following warnings are appearing:

/usr/local/bundle/gems/database_cleaner-core-2.0.1/lib/database_cleaner/cleaner.rb:85: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call
/usr/local/bundle/gems/database_cleaner-nobrainer-1.0.0/lib/database_cleaner/nobrainer/deletion.rb:8: warning: The called method `initialize' is defined here

@zedtux zedtux closed this as completed in 4b837c2 Feb 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zedtux zedtux

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zedtux